Feature/materialise improvement #1773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljeub-pometry
force-pushed
the
feature/MaterialiseImprovement
branch
from
6f6ad10 to
25de963
Compare
…rving the node ids
ljeub-pometry
commented
Sep 13, 2024
ljeub-pometry
commented
Sep 13, 2024
ljeub-pometry
commented
Sep 13, 2024
ljeub-pometry
commented
Sep 13, 2024
ljeub-pometry
commented
Sep 13, 2024
ljeub-pometry
commented
Sep 13, 2024
ljeub-pometry
commented
Sep 13, 2024
ljeub-pometry
commented
Sep 13, 2024
|
And with this PR we now have
I am not a happy puppy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Speed improvements
Does this PR introduce any user-facing change? If yes is this documented?
User-facing apis mostly unchanged but
Edges.iter()now returns references to avoid slowArcclonesHow was this patch tested?
the tests
Issues
closes #1757
Are there any further changes required?
Cleanup of the internal apis